Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove usage of dartdev command #20011

Merged
merged 2 commits into from Jul 24, 2020
Merged

Conversation

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 24, 2020

Description

This is broken on head, just use pub itself.

@jonahwilliams jonahwilliams requested a review from dnfield Jul 24, 2020
@auto-assign auto-assign bot requested a review from liyuqian Jul 24, 2020
Copy link
Member

@dnfield dnfield left a comment

According to @whesse this is a bug in dart and we're using the right command.

Should we just hold off until Dart rolls through with the right fix(es)?

Also, nit: new line at EOF

/cc @jason-simmons

@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Jul 24, 2020

I have no interest in waiting for more dart rolls

@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Jul 24, 2020

Landing to fix build

@jonahwilliams jonahwilliams merged commit 3596b9b into flutter:master Jul 24, 2020
2 of 5 checks passed
2 of 5 checks passed
@cirrus-ci[bot]
build_and_test_linux_unopt_debug Task Summary
Details
@cirrus-ci[bot]
build_test Task Summary
Details
@flutter-dashboard[bot]
Linux Host Engine
Details
@wip[bot]
WIP Ready for review
Details
@googlebot
cla/google All necessary CLAs are signed
@jonahwilliams jonahwilliams deleted the fix_pub_breakage branch Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants