re-enable integration tests. increase sdk version. #20075
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
nturgut
requested review from
ferhatb,
jason-simmons and
jonahwilliams
and removed request for
iskakaushik
jonahwilliams
approved these changes
Jul 28, 2020
LGTM!
ferhatb
reviewed
Jul 28, 2020
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this issue
Jul 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this issue
Jul 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this issue
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Both trees are green now:
https://ci.chromium.org/p/flutter/g/framework/console
https://ci.chromium.org/p/flutter/g/engine/console
Re-enable integration tests.
Increase sdk version, so vscode analysis works in sync with @2.10 annotations.
Add new driver versions since Chrome upgraded to 84 (previously LGTM'ed in PR: #20007)
The text was updated successfully, but these errors were encountered: