Skip to content

/ flutter Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] turn off fuchsia support by default #61634

Merged
merged 5 commits into from Jul 21, 2020
Merged

[flutter_tools] turn off fuchsia support by default #61634

merged 5 commits into from Jul 21, 2020

Conversation

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 16, 2020

Description

Disables fuchsia/ build fuchsia unless flutter config has been used to enable it.

Fixes #52859
@jonahwilliams
[flutter_tools] turn off fuchsia by default
7fb0914
@jonahwilliams
Update build_fuchsia.dart
b52f366
@jonahwilliams
fix precache tests
e8b20b2
@jonahwilliams
Merge branch 'fuchsia_off_by_default' of github.com:jonahwilliams/flu…
78cdd01 
…tter into fuchsia_off_by_default
@jonahwilliams
turn on only fuchsia in fuchsia-attach code
ad11fb0
@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Jul 16, 2020

This will first require another change to the google3 fuchsia features to enable fuchsia

@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Jul 16, 2020

cl/321653131 , but this cannot land until another google3 roll

@jonahwilliams jonahwilliams requested a review from zanderso Jul 16, 2020
@jonahwilliams
Copy link
Member Author

@jonahwilliams jonahwilliams commented Jul 21, 2020

CL has landed, will land this on green.

@fluttergithubbot fluttergithubbot merged commit 8be1c9e into flutter:master Jul 21, 2020
29 checks passed
Pragya007 added a commit to Pragya007/flutter that referenced this issue Aug 11, 2020
@jonahwilliams @Pragya007
[flutter_tools] turn off fuchsia support by default (flutter#61634)
c746532
mingwandroid added a commit to mingwandroid/flutter that referenced this issue Sep 6, 2020
@jonahwilliams @mingwandroid
[flutter_tools] turn off fuchsia support by default (flutter#61634)
2191e99
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso

Assignees
No one assigned
Labels
cla: yes tool waiting for tree to go green
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Guard Fuchsia development in the tool behind a flag
4 participants
@jonahwilliams @zanderso @googlebot @fluttergithubbot