Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop lint on composition event #6

Merged
merged 1 commit into from Jul 29, 2020
Merged

feat: stop lint on composition event #6

merged 1 commit into from Jul 29, 2020

Conversation

@mizchi
Copy link
Contributor

@mizchi mizchi commented Jul 29, 2020

@azu
azu approved these changes Jul 29, 2020
Copy link
Member

@azu azu left a comment

Thanks!

};
const compositionEnd = () => {
onComposition = false;
};

This comment has been minimized.

@azu

azu Jul 29, 2020
Member

Another implementation using handleEvent:

const conpositionState = {
  onComposition: false,
  handleEvent: (event) => {
    switch(event.type){
      "compositionstart":
           conpositionState.onComposition = true;
           return;
      "compositionend":
           conpositionState.onComposition = false;
           return;
    }
  }
};
@azu azu merged commit ac1acb0 into textlint:master Jul 29, 2020
4 checks passed
4 checks passed
@github-actions
Test on Node.js 10
Details
@github-actions
Test on Node.js 12
Details
@github-actions
Test on Node.js 14
Details
@azu
netlify/textlint-editor/deploy-preview Deploy preview ready!
Details
@azu
Copy link
Member

@azu azu commented Jul 29, 2020

close #3

@azu azu mentioned this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants