Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixes OpenAPI Links and makes them optional #72
Conversation
This is important so that the parameters info can be used for Links generation
| @@ -44,15 +44,15 @@ public virtual OpenApiOperation CreateOperation(ODataContext context, ODataPath | |||
| // Security | |||
| SetSecurity(operation); | |||
|
|
|||
| // Parameters | |||
xuzhg
Jul 7, 2020
•
Collaborator
The place of function matters here? #Resolved
The place of function matters here? #Resolved
| IDictionary<string, OpenApiLink> links = new Dictionary<string, OpenApiLink>(); | ||
| foreach (IEdmNavigationProperty np in entityType.DeclaredNavigationProperties()) | ||
|
|
||
| if (!targetMultiplicity) |
xuzhg
Jul 7, 2020
•
Collaborator
if (!targetMultiplicity) [](start = 12, length = 24)
if targetMultiplicity == true, this function seems doing nothing?
Why don't you check this boolean out of this function call?
If (!targetMultiplicity)
{
var links = context.CreateLinks(...);
} #Resolved
if (!targetMultiplicity) [](start = 12, length = 24)
if targetMultiplicity == true, this function seems doing nothing?
Why don't you check this boolean out of this function call?
If (!targetMultiplicity)
{
var links = context.CreateLinks(...);
} #Resolved
irvinesunday
Jul 7, 2020
•
Author
Contributor
Good catch. Resolved. #Resolved
Good catch. Resolved. #Resolved
|
|
| @@ -44,15 +44,15 @@ public virtual OpenApiOperation CreateOperation(ODataContext context, ODataPath | |||
| // Security | |||
| SetSecurity(operation); | |||
|
|
|||
| // Parameters | |||
xuzhg
Jul 15, 2020
Collaborator
// Parameters [](start = 12, length = 13)
Please add a detail comments here to maintenance. For example, we must call SetParameters ahead of ...., and Why?
// Parameters [](start = 12, length = 13)
Please add a detail comments here to maintenance. For example, we must call SetParameters ahead of ...., and Why?
irvinesunday
Jul 20, 2020
Author
Contributor
Added helpful comment.
Resolved
Added helpful comment.
Resolved
|
|
Ths PR fixes #64
Proposes:
operationIdsandparametersof generated OpenAPI Links.booleansetting.Multiple.Schema.OpenApi.jsonandMultiple.Schema.OpenApi.yamltest docs. with sample OpenAPI Link tags and content and updating their respective tests appropriately by enabling Links generation.