New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change from condition z to y #2067

Open

utsavkarkee wants to merge 2 commits into airbnb:master from utsavkarkee:master

utsavkarkee commented Aug 12, 2019

Minor change from condition if(z) return y to
if (y) return y
just for better semantics, in my opinion.

Never mind if that was intended.

utsavkarkee added 2 commits


        Minor change from condition z to y

864b4fe

Changed the condition if (z) return y
to if (y) return y, just to avoid confusion,


        Merge pull request #1 from utsavkarkee/patch-minor-ifCOndition

ebb4c0a

Minor change from condition z to y

Collaborator

ljharb commented Aug 12, 2019

Since both the before and the after example don't convey any semantics, I'm not sure why this change is useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.