Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cookie@0.4.1 #4337

Open
wants to merge 3 commits into
base: 4.18
from

Conversation

@3imed-jaberi
Copy link

@3imed-jaberi 3imed-jaberi commented Jul 3, 2020

Update cookie.

@dougwilson dougwilson added deps pr labels Jul 3, 2020
@3imed-jaberi 3imed-jaberi reopened this Jul 3, 2020
@3imed-jaberi 3imed-jaberi changed the base branch from master to 4.18 Jul 3, 2020
Copy link
Member

@dougwilson dougwilson left a comment

Thank you @3imed-jaberi ! Would you mind updating the commit message to be the same as your PR title (matching the titling of previous commits), update the HISTORY.md file with this change (and what users will see form the change) and update/add any relevant tests around changes this bump brings in? Thank you!

@3imed-jaberi
Copy link
Author

@3imed-jaberi 3imed-jaberi commented Jul 3, 2020

Thank you @3imed-jaberi ! Would you mind updating the commit message to be the same as your PR title (matching the titling of previous commits), update the HISTORY.md file with this change (and what users will see form the change) and update/add any relevant tests around changes this bump brings in? Thank you!

@dougwilson, thanks u for the quick answer... Of course I will update the commit and And I will see about the test coverage because I didn't find any problem, that may have been reduced ..

@3imed-jaberi 3imed-jaberi force-pushed the 3imed-jaberi:update-cookie-to-0.4.1 branch from d2dd9f9 to fb9dd18 Jul 3, 2020
@3imed-jaberi
Copy link
Author

@3imed-jaberi 3imed-jaberi commented Jul 3, 2020

  • Change Commit
  • Update History.md
  • Add Test : I think, we don't need any test.
@dougwilson
Copy link
Member

@dougwilson dougwilson commented Jul 3, 2020

Add Test : I think, we don't need any test. we have the same coverage.

Not all types of changes will change the code coverage; hitting 100% is not difficult and still miss a lot of code paths. For example, does this change in the dependency change the behavior of any of the Express APIs in any way? If so, we should add a test for that changed behavior.

History.md Outdated Show resolved Hide resolved
History.md Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi force-pushed the 3imed-jaberi:update-cookie-to-0.4.1 branch 2 times, most recently from 81bd39a to eb74d25 Jul 3, 2020
History.md Outdated Show resolved Hide resolved
test/res.cookie.js Outdated Show resolved Hide resolved
@3imed-jaberi 3imed-jaberi force-pushed the 3imed-jaberi:update-cookie-to-0.4.1 branch from eb74d25 to 0fc3ed4 Jul 20, 2020
3imed-jaberi and others added 2 commits Sep 28, 2020
Co-authored-by: Douglas Wilson <67512+dougwilson@users.noreply.github.com>
@3imed-jaberi
Copy link
Author

@3imed-jaberi 3imed-jaberi commented Oct 4, 2020

@dougwilson, can I open new PR for fix and format all the code in Standard JS style ?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.