Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updeps: cookie@0.4.1 #4337
deps: cookie@0.4.1 #4337
Conversation
|
Thank you @3imed-jaberi ! Would you mind updating the commit message to be the same as your PR title (matching the titling of previous commits), update the HISTORY.md file with this change (and what users will see form the change) and update/add any relevant tests around changes this bump brings in? Thank you! |
@dougwilson, thanks u for the quick answer... Of course I will update the commit and And I will see about the test coverage because I didn't find any problem, that may have been reduced .. |
d2dd9f9
to
fb9dd18
|
Not all types of changes will change the code coverage; hitting 100% is not difficult and still miss a lot of code paths. For example, does this change in the dependency change the behavior of any of the Express APIs in any way? If so, we should add a test for that changed behavior. |
81bd39a
to
eb74d25
eb74d25
to
0fc3ed4
Co-authored-by: Douglas Wilson <67512+dougwilson@users.noreply.github.com>
|
@dougwilson, can I open new PR for fix and format all the code in Standard JS style ?! |
Update cookie.