Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve python3 & finding moreutils parallel #627

Merged
merged 2 commits into from Sep 20, 2020
Merged

Conversation

@robbat2
Copy link
Contributor

@robbat2 robbat2 commented Aug 3, 2020

The testcase w/ Python doesn't really need Python3, it just needs to validate python; so use ast instead of compiler, which is available in Py3.

Also support moreutils on other Linux distributions where the parallel binary might have a different location, e.g. Gentoo.

@cainejette cainejette requested a review from github/backup-utils Aug 4, 2020
test/testlib.sh Outdated Show resolved Hide resolved
Copy link
Member

@ryansimmen ryansimmen left a comment

Looks good to me. Only one small suggestion. Thank you for making this change.

@robbat2 robbat2 force-pushed the robbat2:gentoo branch from 2465d6c to 04d352a Aug 7, 2020
@ryansimmen
Copy link
Member

@ryansimmen ryansimmen commented Aug 7, 2020

@robbat2 please sync your fork with the latest master, merge master into your branch and push for the Actions tests to run in this PR. Thank you.

robbat2 added 2 commits Aug 3, 2020
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
@robbat2 robbat2 force-pushed the robbat2:gentoo branch from 04d352a to 483298b Sep 19, 2020
@robbat2
Copy link
Contributor Author

@robbat2 robbat2 commented Sep 19, 2020

@ryansimmen rebased on master now

@ryansimmen ryansimmen merged commit 2e71786 into github:master Sep 20, 2020
2 checks passed
2 checks passed
build (ubuntu-latest)
Details
build (macos-latest)
Details
@jianghao0718 jianghao0718 added bug and removed bug labels Sep 23, 2020
@jianghao0718 jianghao0718 changed the title Improve Python3 & Finding Moreutils Parallel Improve python3 & finding moreutils parallel Sep 23, 2020
This was referenced Sep 23, 2020
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Sep 23, 2020
FULL upstream Py3 support added (partial support was present before)

Reference: github/backup-utils#627
Fixes: https://bugs.gentoo.org/735200
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.