Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version should not be called 9.3.5-canary, it should be at least 9.4-pre, or 10.0-pre #420

Open
paulmillr opened this issue Nov 2, 2019 · 5 comments

Comments

@paulmillr
Copy link

@paulmillr paulmillr commented Nov 2, 2019

Also, time to release a new version. It's been ages since 9.3.4.

@kennetpostigo
Copy link

@kennetpostigo kennetpostigo commented Mar 25, 2020

Any chance the next release might be cut soon? Also seems like a pretty important Pull Request hasn't gotten brought in.

@AubreyHewes
Copy link

@AubreyHewes AubreyHewes commented Oct 9, 2020

@paulmillr You should probably describe why the topic/issue has a meaning to you. i.e. describe why not and your issues with it?

The use of canary or pre is superfluous in semver.
The use of canary for code is an old (and also noticeably very new) usage of try and die code.. i.e. bring the canary in.

@kennetpostigo Other issue / Create another issue.

@paulmillr
Copy link
Author

@paulmillr paulmillr commented Oct 9, 2020

@AubreyHewes 9.3.5-canary is very different from 9.3.4. Like, "a new release" different. Naming it 9.3.5 feels like it's a simple patch-version bugfix.

@AubreyHewes
Copy link

@AubreyHewes AubreyHewes commented Oct 12, 2020

@paulmillr You are correct, but the 9.3.5-canary.X version is not npm published... unless you use the github source... so you will never have a problem. It is the code canary version x of the 9.3.5 patch ;-)

I get what you meant, let's not get into a thing about it, sorry if it it sounded like that 👍 Also waiting for the next release ;-)

@paulmillr
Copy link
Author

@paulmillr paulmillr commented Oct 13, 2020

Screen Shot 2020-10-13 at 10 09 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.