Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
docs: changed return type of useEffect() #847
Merged
Conversation
Changed return type of arrow function used within an useEffect to return an object instead of a boolean. This way TypeScript won't complain about your code.
|
Deploy preview for react-navigation-docs ready! Built with commit e1c97a7 https://deploy-preview-847--react-navigation-docs.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi,
thanks for creating and maintaining such a great lib.
I stumbled upon a typo in the docs for V5. The return type for an arrow function within an useEffect should return an object instead of a boolean. This way TypeScript won't complain about a return type other than void.
This is for version 5 of react-navigation only and therefore only changed in the corresponding versioned_docs.