Skip to content

/ gopher-lua

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #120 : safe unsafeFastStringToReadOnlyBytes. #121

Open
wants to merge 1 commit into
base: master
from
Open

Issue #120 : safe unsafeFastStringToReadOnlyBytes. #121

wants to merge 1 commit into from

Conversation

@fiatjaf
Copy link

@fiatjaf fiatjaf commented May 9, 2017

Fixes #120.

Changes proposed in this pull request:

  • provide a safe version of unsafeFastStringToReadOnlyBytes to be used when compiling code for environments that don't support the "unsafe" package.
@fiatjaf
Issue #120 : safe unsafeFastStringToReadOnlyBytes.
Loading status checks…
5be9709 
provide a safe version of unsafeFastStringToReadOnlyBytes
to be used when compiling code for environments that don't
support the "unsafe" package.
fiatjaf added a commit to fiatjaf/glua that referenced this pull request May 9, 2017
@fiatjaf
eliminated unsafe bugs in gopher-lua.
dd44080 
compiling from this commit here: yuin/gopher-lua#121
@yuin
Copy link
Owner

@yuin yuin commented May 15, 2017

This PR just seems a workaround for your problem, I can not accept this PR as it is.

  • alloc.go also uses the unsafe package. This means that the appengine build tag will not work.
  • lack of tests. The unit testing(Make target) and the CI(.travis.yaml) should be added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@fiatjaf @yuin
You can’t perform that action at this time.