-
Notifications
You must be signed in to change notification settings - Fork 629
[rush] Add 'myrush' binary that invokes globally installed Rush version #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
You mean if you have an older version installed globally? We should probably print a warning in that case. Maybe we just shouldn't let that happen? However, I could see someone wanting to be able to easily downgrade a repo. @octogonz - what do you think?
I think for this, we'd want to consider putting together a formal upgrader. Unfortunately, there are tons of cases to consider. It currently overwrites everything because an upgrader would be difficult to write and we weren't sure how much use it would get.
Yeah that looks right to me, assuming your VSCode window is open to the repo root. I usually run |
Currently if rush.json version is higher than the globally installed version, Rush will install it for you. In the case where your rush.json version is lower than that installed globally, Are there any other cases for the |
|
FYI we recently reformatted the master branch using Prettier, which creates merge conflicts for existing PRs. We'll try to fix up the existing PRs for people, but if you want to do it yourself, here's the steps:
|
|
Rush init was updated with #1956 |
…' into updateRushInit
As suggested in #1475 I have updated the error messages a bit. @octogonz is there any thing else I should consider? |
I bypass version selector just checking if command name is 'myrush'. If not it continues with its expected behavior. Let me know if i'm going about it correctly.
WIP (Please comment if I need to add any more)
Questions
rush init --overwrite-existingwill still use an older version from rush.json. Is this necessary?--overwrite-existing, overwrites everything. What if you just want to update versions in the rush.json to the globally installed Rush version, without overwriting other properties?Also am I debugging correctly? Below are my launch configs for
rushandmyrushbinariesThis PR will close #1475