via3 - iptables qa revert #107
Closed
Conversation
|
LGTM. I noted a comment which doesn't read correctly. |
| ## - all tcp ports except 80 and 443 | ||
| ## The rules allow: | ||
| ## - udp port 53 for dns queries | ||
| ## This adds a rule to iptables at the DOCKER-USER chain which all traffic from which |
robertknight
Aug 12, 2020
Member
The first sentence of this comment doesn't parse ("which all traffic from which all traffic from the container").
The first sentence of this comment doesn't parse ("which all traffic from which all traffic from the container").
|
Closing - I will create another PR if we need to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Unfortunately I looking to revert the
iptablesrules on via3 qa. I have detailed my reasoning in on the original issue: hypothesis/via3#218 (comment)This branch reinstates the configuration as it was before testing was started.
Let me know if you have any questions.