Skip to content

/ node-core-utils

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git land stuck on windows #358

Closed
gengjiawen opened this issue Jun 20, 2019 · 7 comments
Closed

git land stuck on windows #358

gengjiawen opened this issue Jun 20, 2019 · 7 comments
Labels
stale

Comments

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jun 20, 2019

The second prompt (sorry for not keeping the message) after type Y, the command stucked, both in cmd and git-bash.

Env info

 System:
    OS: Windows 10 1903
    CPU: (8) x64 Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz
    Memory: 7.14 GB / 15.89 GB
  Binaries:
    Node: 12.4.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 5.6.0 - C:\Program Files\nodejs\npm.CMD

cc @gireeshpunathil @mcollina
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Jun 20, 2019

I cant reproduce this, but I saw it for sure in the remote screen of @gengjiawen when we were onboarding him. :)
@richardlau
Copy link
Member

@richardlau richardlau commented Jun 20, 2019 •
edited

Could it be related to #356 (something prompting for input)?
@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Jun 27, 2019

Today I launched a new PR, same stuck place

? This PR should be ready to land, do you want to continue? Yes
   √  No git am in progress
   √  No git rebase in progress
--------------------------------------------------------------------------------
? Do you want to try reset the local master branch to upstream/master? (Y/n)
@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jun 27, 2019 •
edited

I think it may be related to #356 - there is a prompt from git and we are not handling it correctly.
@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Jun 27, 2019

I think it may be related to #356 - there is a prompt from git and we are not handling it correctly.

My ssh key has no password, is it still the case ? Also can I change some file to show the extra info so I can get more info in my case.
@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jun 27, 2019

@gengjiawen there are other cases where git may prompt and wait for an answer e.g. the upstream server you are creating an ssh connection to is unknown. It's possible that write like this:

node-core-utils/lib/session.js

Line 295 in f3f59da

cli.startSpinner(`Bringing ${branchName} up to date...`);

covers the prompt from git. The fix would be to pay attention to commands like this that send a prompt, don't wrap it with spinners, and pipe the stdin into it when necessary.
@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 15, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
@github-actions github-actions bot added the stale label Aug 15, 2020
@github-actions github-actions bot closed this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@gengjiawen @joyeecheung @richardlau @gireeshpunathil
You can’t perform that action at this time.