feat: support metadata query by userid #397
Conversation
"git node metadata @srl295" will show up to 10 active PRs and give the current status.
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 76.28% 76.28%
=======================================
Files 21 21
Lines 1480 1480
=======================================
Hits 1129 1129
Misses 351 351 Continue to review full report at Codecov.
|
| await getOneMetadata(nargv, cli, request); | ||
| cli.separator(); | ||
| } | ||
| return {}; // ? |
srl295
Mar 21, 2020
Author
Member
not sure what the return should be here
not sure what the return should be here
joyeecheung
Mar 30, 2020
•
Member
I think a better way to handle multiple requests is to add a different method for it, which calls the old getMetadata, and then call it from the command handler, instead of overwriting the method that's used to querying single requests. That also helps you avoid the nargv.assignee tinkering.
node-core-utils/components/git/metadata.js
Lines 83 to 88
in
1e9daeb
In addition you may want to update the fs.writeFileSync call in getMetadata to fs.appendFile instead.
I think a better way to handle multiple requests is to add a different method for it, which calls the old getMetadata, and then call it from the command handler, instead of overwriting the method that's used to querying single requests. That also helps you avoid the nargv.assignee tinkering.
node-core-utils/components/git/metadata.js
Lines 83 to 88 in 1e9daeb
In addition you may want to update the fs.writeFileSync call in getMetadata to fs.appendFile instead.
| await getOneMetadata(nargv, cli, request); | ||
| cli.separator(); | ||
| } | ||
| return {}; // ? |
joyeecheung
Mar 30, 2020
•
Member
I think a better way to handle multiple requests is to add a different method for it, which calls the old getMetadata, and then call it from the command handler, instead of overwriting the method that's used to querying single requests. That also helps you avoid the nargv.assignee tinkering.
node-core-utils/components/git/metadata.js
Lines 83 to 88
in
1e9daeb
In addition you may want to update the fs.writeFileSync call in getMetadata to fs.appendFile instead.
I think a better way to handle multiple requests is to add a different method for it, which calls the old getMetadata, and then call it from the command handler, instead of overwriting the method that's used to querying single requests. That also helps you avoid the nargv.assignee tinkering.
node-core-utils/components/git/metadata.js
Lines 83 to 88 in 1e9daeb
In addition you may want to update the fs.writeFileSync call in getMetadata to fs.appendFile instead.
| * @param {Object} request | ||
| */ | ||
| constructor(argv, cli, request) { | ||
| const { assignee, owner, repo } = argv; |
joyeecheung
Mar 30, 2020
Member
I think it's probably enough to just pass these directly here instead of through argv - this is very far away from the command handler now and argv isn't too meaningful here.
I think it's probably enough to just pass these directly here instead of through argv - this is very far away from the command handler now and argv isn't too meaningful here.
|
@srl295 do you think this is something you still want to work on? |
|
Can't now, job change
…________________________________
From: Shelley Vohr <notifications@github.com>
Sent: Tuesday, July 14, 2020 4:48:29 PM
To: nodejs/node-core-utils <node-core-utils@noreply.github.com>
Cc: Steven R. Loomis <srl295@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nodejs/node-core-utils] feat: support metadata query by userid (#397)
@srl295<https://github.com/srl295> do you think this is something you still want to work on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#397 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGQZMYUA2R7NBNYI3NPY2TR3TVE3ANCNFSM4LQXCC3Q>.
|
|
This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
git node metadata @srl295will show up to 10 active PRs and give the current status.I'm not a frequent contributor to node. But, sometimes I have a couple of different PRs in the works. This helps me find out what the current status is.