Skip to content

/ vscode-jupyter Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test compile failure in nyc #734

Closed
rchiodo opened this issue Aug 13, 2020 · 1 comment
Closed

Unit test compile failure in nyc #734

rchiodo opened this issue Aug 13, 2020 · 1 comment
Assignees
@DonJayamanne
Labels
code-health

Comments

@rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Aug 13, 2020

https://github.com/microsoft/vscode-python/runs/978217920

Error:

TSError: ⨯ Unable to compile TypeScript:
##[error]src/client/datascience/notebookStorage/vscNotebookModel.ts(96,13): error TS2322: Type '({ metadata: { [x: string]: string | number | boolean | JSONObject | JSONArray | null | undefined; format?: string | undefined; trusted?: boolean | undefined; name?: string | undefined; jupyter?: Partial<...> | undefined; tags?: string[] | undefined; } | { ...; } | { ...; } | { ...; } | { ...; }; cell_type: "raw"; a...' is not assignable to type 'ICell[]'.
@DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Aug 17, 2020

This is a weird issue with ts-node.
Works on Azure CLI, works on Mac CLI locally, but not on GitHub Actions.

@rchiodo rchiodo closed this Aug 20, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
code-health
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@DonJayamanne @rchiodo