Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMQ-7325] Upgrade to Derby 10.15.1.3 #402

Open
wants to merge 1 commit into
base: master
from

Conversation

@jbonofre
Copy link
Member

jbonofre commented Oct 31, 2019

No description provided.

@jbonofre
Copy link
Member Author

jbonofre commented Oct 31, 2019

EmbeddedDataSource needs an update. I'm fixing.

@jbonofre jbonofre force-pushed the jbonofre:AMQ-7325 branch from 8ab30ee to 4590a1d Oct 31, 2019
@gemmellr
Copy link
Member

gemmellr commented Oct 31, 2019

Derby 10.15.1.3 requires Java 9 to run. Changing the minimum JDK requirements to 9+ seems like it would be a discussion topic.

@jbonofre
Copy link
Member Author

jbonofre commented Oct 31, 2019

@gemmellr that's for master

@jbonofre
Copy link
Member Author

jbonofre commented Oct 31, 2019

But agree to be discussed

@gemmellr
Copy link
Member

gemmellr commented Oct 31, 2019

I know its on master but to me the branch isnt that important, still seems like a discuss-before-commit type of change, especially if a release from the branch was already proposed to happen.

@jbonofre
Copy link
Member Author

jbonofre commented Oct 31, 2019

@gemmellr agree, I will start a thread on the mailing list about 5.16.0 minimum Java version. My understanding is to fully support Java 9+, but let's double check.

@jbonofre
Copy link
Member Author

jbonofre commented Oct 31, 2019

@gemmellr just started the discussion on the mailing list.

@gemmellr
Copy link
Member

gemmellr commented Oct 31, 2019

I'm not arguing either way, just saying it needs discussed first, given its happening well after a release was proposed. I would say supporting 9+ doesn't necessarily need to mean dropping 8, unless folks want to. Obviously Derby have done that though, so clearly folks are starting to do it.

@gemmellr
Copy link
Member

gemmellr commented Oct 31, 2019

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.