Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIonic 4.0.0 RTL issues #17012
Ionic 4.0.0 RTL issues #17012
Comments
|
Scroller inside |
|
Yes indeed, |
|
@Newbie012 I noticed it's only the case with the AlertController interface, and in MD. Can you please verify? |
|
@abennouna True |
|
Thanks @Newbie012, added to the list under the |
|
I updated the original issue to include links to some of the open RTL issues. We can either keep those open for tracking or close them to track here. |
|
@abennouna I notice that dir option is removed form ion-slides in v4 which is supposed to RTL when using slides component. May I know will it be added back or is there any alternative way to achieve it? |
|
@twinssbc slides work in RTL mode out of the box as long as the document is in RTL. Are you referring to something else? PS: There is an issue though if you want to switch direction dynamically: you'd have to reload the document to keep swiper events working correctly |
|
@abennouna I would like to thank you for your effort in making sure that all RTL issues are fixed. I just want to mention that items inside ion-item-divider in RTL has different margins with both slot="start" and slot="end" than in LTR |
|
@abuassar Good call! I see a 2px margin that disappears in RTL mode, only in MD. Can you confirm please? |
It is not just 2px error, please check the following screen shots: START uses slot="start" and here is how to recreate the issue https://gist.github.com/abuassar/bdee78a37e36cf1c5e7ddc506eed141d |
|
unfortunately I found the same issue with ion-item: START uses slot="start" demo: |
|
@abuassar am I right to assume you're not using the latest master with PR #16987? I updated the issue description to explain the test context. Here's the current render of the issue in |
|
@abennouna you are right, I'm using rc1 as I thought it has the fix. Would you please guide me how to use latest master with the said PR? |
|
@abuassar I updated the issue description with the following in the "Contributing" part:
Please let me know if it's unclear. |
@abennouna I can confirm that slides work in the default RTL mode, no extra option is required. |
@brandyscarney I can reproduce now in Safari. Also, not sure if it helps: take .ion-float-start,
[float-start] {
float: left !important;
}
[dir=rtl] .ion-float-start,
:host-context([dir=rtl]) .ion-float-start,
[dir=rtl] [float-start],
:host-context([dir=rtl]) [float-start] {
float: right !important;
}(Safari needs the non- |
|
Thanks @abennouna! Can you update the issue for this? Maybe we need to update the |
|
@brandyscarney issue updated. Returning 2 selectors in |
|
@abennouna What about ion-item-sliding RTL issue? |
|
@shahramSo Sorry for that, see Brandy’s comment below |
|
@shahramSo The item sliding issue is fixed, it just hasn't been in a release yet. It will be in the |
|
@brandyscarney Is there any way I can re-use the same SCSS written in ionic 3 app ? It throws me an error "No mixin named padding" |
|
The menu works when set on startup (opens up from the right). But when it is set/changed dynamically it will open from the left. Is this a known issue? See: https://enappd.com/blog/rtl-right-to-left-use-in-ionic-4/50/ Is there any development/progress regarding RTL (when is it planned to be included in Ionic4)? Or is this community driven effort? |
|
this issue: #17012 (comment) still exist in real ios device/simulator but not in browser ! ionic version: 4.7.1 |
|
this is happening because of the following style:
removing unset will solve the problem but I am not sure how to override/cancel it |
|
Not sure if this will work, I don't have access to test it, but maybe you
can try
:host( .fab-horizontal-center):lang(en) {
margin-left: unset;
}
https://www.w3schools.com/cssref/sel_lang.asp
…On Tue, Aug 6, 2019 at 10:37 PM Adel Ali ***@***.***> wrote:
this is happening because of the following style:
:host( .fab-horizontal-center) {
margin-left: unset;
}
removing unset will solve the problem but I am not sure how to
override/cancel it
I tried all other values for margin but they didn't work
only removing it will fix the issue!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17012>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHJ3YPFJSDPK4KG7ZKD7BLQDHHIHANCNFSM4GO4IEFQ>
.
|
|
thanks @mrahmadt but that didn't work the solution is: in global.scss
also I notice that fab start position is not changing direction in RTL mode in ios simulator/device |
|
ion-slides rtl is not working properly ? |
|
Hello, i have a problem with side menu in real IOS devices |
|
@brandyscarney |
|
any update on the RTL support for ion-slides if I changed document dir to RTL the ion-slide stop sweeping between slides |
It swipes but in the wrong direction |
|
@abennouna i still see the issue "select icon in iOS: fix position of the inner element" on the current version, although its supposed to be fixed according to the issue description. |
|
@abennouna It looks like columns in Previous work seems to indicate this is intentional:
Do you recall the reasoning behind this? |
|
Hello Everyone, Second: |
|
Hey. I wonder if swipe to go back direction is already solved or not. Because the direction is not changing right now. |
|
|
this is not working for me too.. |
|
@ChiragPrajapat, I recently reported a bug for this issue and show a walkthrough about that, check it and hope, it is useful for you. |





This issue is to collect and keep track of RTL bugs vs. master so we can make sure to properly update and fix them.
Below are:
Legend
Fixed issues
CSS Utilities
text-start,text-end,text-justify, & their responsive versionsfloat-start,float-end, & their responsive versions (regression: #17012 (comment)) (PR #18315 solves issue in Chrome)padding-start,padding-endmargin-start,margin-endjustify-content-start,justify-content-endGrid
Components
labelissues are listed in the relevant components, and the issue with label and input vertical alignment is not specific to RTL)select,range, and floatinglabelissues in relevant components)cancelButtonIconproperty allows setting own icon?alertcomponentExisting Issues as of
4.4.1slot="start"andslot="end", a small2pxmargin appears on one side in LTR, but not on the opposite side in RTL (see https://i.imgur.com/4W5TFs2.png for an illustration of the problem: the box model shows the slotted ion-button)float-start,float-end, & their responsive versions in SafariContributing
Please help with the untested components, or double-check the tested ones if you feel like it. Thank you for the contribution anyway!
If you're not familiar with the included test suite:
?rtl=trueto the url in order to check the RTL version;See the contributing documentation for more information.
You can also test your own app using
@ionic/angular@dev