Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix LineMarkSeries blocking pointer events on other LineMarkSeries #1152
Conversation
CLAassistant
commented
Apr 10, 2019
•
|
|
This was referenced Apr 10, 2019
|
Now that I thought about this more, shouldn't this bug also appear when using just |
bmaupin
commented
Jun 27, 2019
|
This should fix #1157 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
samulisuomi commentedApr 10, 2019
Fixes #1004 (and probably #1099 (comment)).
Issue
Having multiple
LineMarkSeriesoverlapping in a single plot may result in some of the marks not firing theonValueMouseOvercallback.This is because the
LineMarkSeriesdraws an invisible area with the<plot>that is blocking pointer events on marks rendered behind it. I've setlineStyle={{ fill: "#80808080" }}in my codesandboxes to highlight this otherwise invisible area.Before
https://codesandbox.io/s/43q7xyq3vw
After
https://codesandbox.io/s/xp3w5kly1p