Skip to content

/ react-vis

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Storybook for local development. #1352

Open
wants to merge 1 commit into
base: master
from
Open

Allow using Storybook for local development. #1352

wants to merge 1 commit into from

Conversation

@Xiot
Copy link
Contributor

Xiot commented Jun 7, 2020

Storybook is an easy to use UI to enable testing out features.
This allows storybook to pick up changes from react-vis/src so that it
can be used while developing components.
@Xiot
Allow using Storybook for local development.
Loading status checks…
2bef0c6 
Storybook is an easy to use UI to enable testing out features.
This allows storybook to pick up changes from react-vis/src so that it
can be used while developing components.
@Xiot
Copy link
Contributor Author

Xiot commented Jun 7, 2020

I realize that its baking in some of the external config, but it only does it for development.

Previously, the storybook, used react-vis from the node_modules, so if you wanted to make a change and see it in storybook, you had to

  1. make the change
  2. stop storybook
  3. yarn build on react-vis
  4. start up the storybook.

With this, the development cycle becomes.

  1. start storybook
  2. make a change to the component.
  3. repeat step 2.

This greatly enhances the flow.

I really like developing with storybook because of the ability to add knobs. You end up with a fairly fluid experience.

When I was digging into #1347 I actually set up a storybook as it allowed me to easily visualize and test what was going on. Unfortunately I had to follow the painful original flow of stopping, changing, building, starting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@Xiot
You can’t perform that action at this time.