I've expanded this PR to use BlockstackWallet wherever possible.

Because blockstack.js has upgraded to bitcoinjs-lib@4.x.x, we'll need to do the same in this repo. Unfortunately that's going to be a lot of effort because all HDNode usage was replaced with bip32 usage.

This is updated to work with the latest from this PR: blockstack/blockstack.js#433

I recommend testing this by restoring an old account, logging into multiplayer apps (which should continue to work with the same app private key that you used before if you had previously logged in) and single player apps, and by creating a new user and logging in and out of apps.

@kantai should this issue be considered resolved and closed out based on your PR? #1620

Nope -- as far as I understand, we still are using the short app derivation paths.

@kantai What's the main benefit here? Stronger security or?

@kantai What's the main benefit here? Stronger security or?

Yep -- this would increase the security of the app-derived keys.

@kantai Sounds good – it seems this PR is almost across the finish line and just needs a bit more testing. Is that the case? I'm moving this to the backlog so we can prioritize for the next sprint assuming that's the case.

Unless I'm mistaken, this is not backwards compatible with single-player apps, because they aren't in the apps key. So if you login to a single-player app, your data and private key will not be the same.