Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CX truth table #278

Closed
vadym-f opened this issue Jun 15, 2020 · 3 comments · Fixed by #345
Closed

CX truth table #278

vadym-f opened this issue Jun 15, 2020 · 3 comments · Fixed by #345
Labels
Area-Documentation good first issue Kind-Bug

Comments

@vadym-f
Copy link

@vadym-f vadym-f commented Jun 15, 2020

It seems '11' input is missing in the truth table.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@vadym-f vadym-f changed the title 11 input for CX 11 input for CX truth table Jun 15, 2020
@vadym-f vadym-f changed the title 11 input for CX truth table CX truth table Jun 15, 2020
@jainvasu631
Copy link

@jainvasu631 jainvasu631 commented Jun 17, 2020

I think the problem is not with the input but incorrect rendering of CX Unitary

https://github.com/MicrosoftDocs/quantum-docs-pr/blob/e23178d32b316d05784a02ba3cd6166dad177e89/api/qsharp/microsoft.quantum.canon.cx.yml#L13-L20

@cgranade
Copy link
Member

@cgranade cgranade commented Jun 17, 2020

Thanks for highlighting this, it looks like there's a missing \left(\begin{matrix} / \end{matrix}\right) in the LaTeX source used to typeset this comment. As this is API documentation, it will need to be fixed in the Q# source at https://github.com/microsoft/QuantumLibraries/blob/master/Standard/src/Canon/CommonGates.qs#L10.

@cgranade
Copy link
Member

@cgranade cgranade commented Jun 17, 2020

@KittyYeungQ: It looks like this one got incorrectly redirected to microsoft/quantum instead of microsoft/quantumlibraries; we should fix that in the .openpublishing.config.json file on the docs repo.

@cgranade cgranade transferred this issue from microsoft/Quantum Jun 17, 2020
@ihristova11 ihristova11 mentioned this issue Oct 9, 2020
Merged
@msoeken msoeken closed this in #345 Oct 20, 2020
msoeken added a commit that referenced this issue Oct 20, 2020
@ihristova11 @msoeken @cgranade
Fix #278 CX truth table (#345)
543b240 
* Update CommonGates.qs

* Update Standard/src/Canon/CommonGates.qs

* Update Standard/src/Canon/CommonGates.qs

Co-authored-by: Chris Granade <cgranade@gmail.com>

Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Chris Granade <cgranade@gmail.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Documentation good first issue Kind-Bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix #278 CX truth table
3 participants
@cgranade @vadym-f @jainvasu631