Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add support for OpenStack Barbican #683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 37.11% 37.28% +0.16%
==========================================
Files 21 23 +2
Lines 2891 3420 +529
==========================================
+ Hits 1073 1275 +202
- Misses 1724 2014 +290
- Partials 94 131 +37
Continue to review full report at Codecov.
|
|
Please submit your patch against the |
Add a new KMS backend for OpenStack Barbican. The logic is slightly different from the other KMSs as Barbican is used to store/retrieve the master keys, with the encryption of the data keys being done by sops.
|
@jvehent done |
|
@rochaporto Thank you for the PR. I must say, I am currently against merging this unless:
|
|
Hi @ajvb . Thanks for the feedback. I'll work on the testing guide and integration tests, and in parallel inquire about interest by other people within openstack. Thanks for checking this out. |
Adds a new keysource storing master keys under OpenStack Barbican:
https://wiki.openstack.org/wiki/Barbican
As described in the commit message, the logic is different from the other keysources as Barbican does not directly offer encrypt/decrypt logic, but works instead as a secret storage service. In this keysource we rely on Barbican to store and retrieve the master keys.
The PR is built on top of the Vault one, i'm happy to rebase if necessary against current master.