Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: Add 3.6 to build matrix #37
Merged
Conversation
EvanPurkhiser
force-pushed the
evanpurkhiser/build-add-36-to-build-matrix
branch
10 times, most recently
from
6be1973
to
64cfe4c
Closed
|
Travis CI build config validation issues to resolve: |
|
ooh, thanks @cclauss :) |
EvanPurkhiser
force-pushed the
evanpurkhiser/build-add-36-to-build-matrix
branch
2 times, most recently
from
451aab0
to
92c3c87
|
I think they should be fixed now! |
|
LGTM. I would encourage you to add a Python 3.8 test even if you do not yet plan to use it because there were some key changes in Py37 and Py38 and it would be good to catch them early. Python 3.9 is released in about one month. |
|
Yeah sounds good. We're targeting 3.6 for sentry right now and making good progress, then we'll be able to start making those incremental jumps. It's definitely been a struggle to get there, but we're getting close! |
EvanPurkhiser
force-pushed the
evanpurkhiser/build-add-36-to-build-matrix
branch
from
92c3c87
to
977c4b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
EvanPurkhiser commentedAug 12, 2020
•
edited