Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve work with StringBuilder to decrease memory traffic and to imp… #1460

Open
wants to merge 1 commit into
base: main
from

Conversation

@DamirAinullin
Copy link
Contributor

@DamirAinullin DamirAinullin commented May 10, 2020

…rove perfomance

@NickCraver
Copy link
Member

@NickCraver NickCraver commented May 10, 2020

A general issue here is it'll break many existing PRs, but on the other hand: they're all breaking changes to column quoting/casing that can't be merged.

Overall for v3 I'm thinking of drastically changing the interface, maybe making it a base class where Insert<T> is what you implement...rather than the adapter. The adapters are just so brittle as so many issues have shown, and what people want to change on casing, etc. If they could be overridden directly, more easily scoped to each provider, PRs to fix one wouldn't break all others, etc. I need to write up ideas for .Contrib v3 (and general), but...yeah, minor brain dump there.

I'm fine with this as-is, given we can't merge the conflicting PRs anyhow. @mgravell thoughts?

@NickCraver NickCraver changed the base branch from master to main Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.