Skip to content

/ peps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect backticks #1560

Merged
merged 1 commit into from Aug 12, 2020
Merged

Fix incorrect backticks #1560

merged 1 commit into from Aug 12, 2020

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 12, 2020

Like #1559, for:

  • PEP 445
  • PEP 467
  • PEP 548
  • PEP 621

Found with:

$ git grep "[A-Za-z0-9]\`\`[A-Za-z0-9]"
pep-0445.txt:``PyMem_Realloc()`` indirectly call``PyObject_Malloc()`` and
pep-0467.txt:This PEP proposes that ``bytes`` and ``bytearray``gain an optimised
pep-0548.rst:Reading this we first see the``break``, which obviously applies to
pep-0621.rst:for using``long_description`` and a corresponding
@hugovk
Fix incorrect backticks
Loading status checks…
534b463
@gvanrossum
gvanrossum approved these changes Aug 12, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Excellent!

I wonder if we could have a PEP linter that rejected such mistakes in new contributions.
@gvanrossum gvanrossum merged commit 3301169 into python:master Aug 12, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hugovk hugovk deleted the hugovk:fix-backticks branch Aug 12, 2020
@hugovk
Copy link
Contributor Author

@hugovk hugovk commented Aug 12, 2020

Yes, I was about to add one to avoid the single backticks, and it's based on grep, so I'll see about adding a rule for this too!
@hugovk hugovk mentioned this pull request Aug 12, 2020
Merged
AA-Turner added a commit to AA-Turner/peps that referenced this pull request Aug 15, 2020
@hugovk @AA-Turner
PEP 445, PEP 467, PEP 548, PEP 621: Fix incorrect backticks (python#1560
460fa5c 
)
@hugovk hugovk mentioned this pull request Aug 15, 2020
Closed
@hugovk hugovk mentioned this pull request Oct 21, 2020
Open
mnm678 added a commit to mnm678/peps that referenced this pull request Oct 22, 2020
@hugovk @mnm678
PEP 445, PEP 467, PEP 548, PEP 621: Fix incorrect backticks (python#1560
e699ab6 
)
gaborbernat added a commit to gaborbernat/peps that referenced this pull request Dec 13, 2020
@hugovk @gaborbernat
PEP 445, PEP 467, PEP 548, PEP 621: Fix incorrect backticks (python#1560
Verified
This commit was signed with a verified signature.
gaborbernat Bernát Gábor
GPG key ID: 389A324926656E0D Learn about signing commits
3b55774 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@hugovk @gvanrossum @the-knights-who-say-ni