Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeleteDictionaryAndItems function #277

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@kochol
Copy link

kochol commented May 17, 2020

No description provided.

@bfiete
Copy link
Collaborator

bfiete commented May 18, 2020

This made me realize I used the wrong name for the "DeleteDictionaryAndKeysAndItems" - it should have been "DeleteDictionaryAndKeysAndValues"

for (var value in container)
{
delete value.value;
}
Comment on lines +185 to +188

This comment has been minimized.

@JamesOrson

JamesOrson Jul 11, 2020

Contributor

Wouldn't it be more appropriate to call the dictionary element an item?

Ex:

for (var item in container)
{
    delete item.value;
}

This comment has been minimized.

@bfiete

bfiete Jul 11, 2020

Collaborator

Or element. I often use kv for key/value pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.