Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification priority #2

Open
wants to merge 1 commit into
base: master
from

Conversation

@Exordian
Copy link

@Exordian Exordian commented Nov 16, 2019

add notification priority for FCM

we're currently sending 'data' messages which include no service-level objective to be delivered. RocketChat should send notifications with priority '10'. this change adds the possibility

https://firebase.google.com/docs/cloud-messaging/http-server-ref

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Nov 16, 2019

CLA assistant check
All committers have signed the CLA.

@geekgonecrazy geekgonecrazy changed the title FCM: add notification priority feat: FCM add notification priority Nov 19, 2019
@geekgonecrazy geekgonecrazy changed the title feat: FCM add notification priority feat: add notification priority Nov 19, 2019
@geekgonecrazy
Copy link
Member

@geekgonecrazy geekgonecrazy commented Nov 20, 2019

@Exordian can you check the ci. I think its failing because the commit doesn't follow its style.. which is weird. But I think thats what they were doing upstream

@Exordian Exordian force-pushed the Catalysts:fcm-add-priority branch from 118d529 to dbe5037 Nov 24, 2019
@Exordian
Copy link
Author

@Exordian Exordian commented Nov 24, 2019

resolved

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 25, 2019

FCM docs says the value is a string where valid values are normal and high .. we're now sending 10 on Rocket.Chat .. so I think we need to proper test this and maybe convert the values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.