ijjk
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Popular repositories
2,874 contributions in the last year
Activity overview
Contribution activity
September 2020
Created a pull request in vercel/next.js that received 6 comments
Provide resolvedUrl to getServerSideProps
This continues off of #17081 and provides this normalized asPath value in the context provided to getServerSideProps to provide the consistent valu…
+141
−26
•
6
comments
- Expose dotenv loading under separate package
- Fix global CSS syntax error
- Fix direct visiting a SSR dynamic page with default params
- Separate resolved asPath from resolved URL for GSSP
- Update webpack 5 resolving
- Fix API page check during SSG page collecting
- Normalize asPath for GS(S)P pages
- Update to check for overlay in client nav tests
- Fix resolving href with a rewrite
- Add error when href interpolation fails
- Correct page path for GS(S)P data refreshing
- Include additional query values when interpolating href
- Fix href resolving with trailing slash enabled
- Correct client rewrite resolving with query
- Fix invalid config export errors
- Update to show build indicator while re-fetching GS(S)P data in dev
- Only update lookups for dev overlay if mounted
- Ensure interpolating dynamic href values works correctly
- Revert "fix: Promise.prototype.finally is object (#16620)"
- Add automatic reloading when editing GS(S)P methods
- Fix invalid href error message
- Add missing comma in docs example
- Polyfill missing std lib fns for module browsers
- Improve custom document error message
- Fix typo in Pet mongoose model
- Use useRouter over Router for with-google-analytics example
- chore(examples): fix missing document components error messages
- Undo unrequired readme changes done to examples
- Add tests for searchParams dev warning
- make parseRelativeUrl return a UrlObject
- Revert #14580
- [test] Update hydration marker for React 17
Created an issue in vercel/next.js that received 2 comments
Client side href resolving breaks with trailingSlash: true
I've /en/software.jsx and /en/[post].jsx files. When I navigated to /en/software/ via Router.push('/en/software/') in v9.5.2 it resolved to /en/sof…
2
comments
- Investigate delaying asPath values for all build-time exported pages
- We need to filter prerender items from the functions list
- Our API page checks should make sure to not match non-API pages
- Supplying a rewrite to next/link should resolve correctly without href and as
- When href interpolation fails we should error properly
- GS(S)P data refreshing doesn't trigger properly for `/index` routes
- Show the build/activity indicator while re-fetching data for GS(S)P being edited
- We should handle interpolating dynamic href values correctly
- The default env file create by the Vercel CLI should match the Next.js recommended filename
4
contributions
in private repositories
Sep 1 – Sep 16