Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typos #27

Open
wants to merge 1 commit into
base: master
from
Open

Minor typos #27

wants to merge 1 commit into from

Conversation

@samparks
Copy link

@samparks samparks commented Jun 17, 2018

Added a period to *.*format(tn= ...

Added a period to *.*format(tn= ...
@rasbt
Copy link
Owner

@rasbt rasbt commented Jun 17, 2018

Thanks! But I see that there are two periods now:

c.execute("UPDATE {tn} SET {cn}='sebastian_r' WHERE {idf}=123456".\
          .format(tn=table_name, idf=id_column, cn=new_column))

Could you please remove the upper one?

@samparks
Copy link
Author

@samparks samparks commented Jun 17, 2018

Ah, sorry! I just realized that the places that I thought periods were needed, were just included above instead of on the new line! I'll let you close this unless you'd like for me to change them all for consistency.

@rasbt
Copy link
Owner

@rasbt rasbt commented Jun 17, 2018

No worries, and I think it's visually a bit misleading. I think we could leave it as is. It has a bit of those "when you see you old code and cringe" moments ;) I would put the period onto the new line if I wrote it today. Sth like

c.execute("UPDATE {tn} SET {cn}='sebastian_r' WHERE {idf}=123456"
          .format(tn=table_name, idf=id_column, cn=new_column))

(the backslash shouldn't be needed because of the parentheses.)

@samparks
Copy link
Author

@samparks samparks commented Jun 17, 2018

👍 sounds good to me. Sorry for the confusion!

@rasbt
Copy link
Owner

@rasbt rasbt commented Jun 17, 2018

No worries, I appreciate it that you submitted a PR helping to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.