Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCache Child Props #1314
Cache Child Props #1314
Conversation
CLAassistant
commented
May 2, 2020
•
|
|
|
Using the 5th graph on the showcase (Line Chart Canvas - in svg mode) I was able to increase the fps while hovering over the graph from about 5 fps to 60 fps. To see this I changed the |
| @@ -56,7 +56,7 @@ test('data-utils #addValueToArray', t => { | |||
| test('data-utils #transformValueToString', t => { | |||
| t.deepEqual(transformValueToString(0), 0, | |||
| 'Shouldn\'t transform the number value'); | |||
| t.deepEqual(transformValueToString(new Date(0)), 'Thu Jan 01 1970', | |||
| t.deepEqual(transformValueToString(new Date(43200000)), 'Thu Jan 01 1970', | |||
This comment has been minimized.
This comment has been minimized.
Xiot
May 2, 2020
Author
Contributor
This value is 12:00 PM which should play nicer with timezone differences.
| @@ -187,6 +187,22 @@ class XYPlot extends React.Component { | |||
| } | |||
| }; | |||
|
|
|||
| _childPropCache = Object.create(null) | |||
This comment has been minimized.
This comment has been minimized.
chrisirhc
May 19, 2020
Contributor
I'm a bit hestiant to add a cache instead of relying on useMemo. How about we wait till the modernization to React 16.8 (#1316) and useMemo instead (after some refactoring of this prop cloning behavior perhaps to using context)?
Alternatively, if you'd like to try out what this looks like via the modernize branch. Feel free to go for it.
Xiot
force-pushed the
Xiot:child-prop-cache
branch
4 times, most recently
from
d747435
to
a2e3f1c
Cache the child props to prevent React from re-rendering unnessesarily. The biggest culprits were the default accessors. The defaults for each attribute are now computed once, and re-used when required.
Xiot commentedMay 2, 2020
Cache the child props to prevent React from re-rendering unnessesarily.
The biggest culprits were the default accessors. The defaults for each
attribute are now computed once, and re-used when required.