Skip to content

/ seq2seq

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#174 fixed that unk_replacement and beam_search work together #271

Open
wants to merge 1 commit into
base: master
from
Open

#174 fixed that unk_replacement and beam_search work together #271

wants to merge 1 commit into from

Conversation

@nem6ishi
Copy link

nem6ishi commented Jul 6, 2017

The issue that unk_replacement and beam_search does not work is solved in this pull request.

The problem is that there is no attension_scores but multiple attension_scores in beam_search which is named "beam_search_output.original_outputs.attention_scores".
So I just added the procedures to pick one of them.
Since it seems that the top of the list is always the best among the beams in beam_search, [:,0,:] of it was taken.

This is my first big pull request and the code does not look beautiful, but I will appreciate if I could get kind instructions for this.
@nem6ishi
fixed that unk_replacement and beam_search work together
Loading status checks…
d429bbe
@googlebot
Copy link

googlebot commented Jul 6, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
@nem6ishi
Copy link
Author

nem6ishi commented Jul 6, 2017

I signed it!
@googlebot
Copy link

googlebot commented Jul 6, 2017

CLAs look good, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nem6ishi @googlebot
You can’t perform that action at this time.