Skip to content

/ samples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[federated_plugin] adds support for Windows #533

Open
wants to merge 2 commits into
base: master
from
Open

[federated_plugin] adds support for Windows #533

wants to merge 2 commits into from

Conversation

@AyushBherwani1998
Copy link
Contributor

AyushBherwani1998 commented Aug 25, 2020 •
edited

Description

  • adds Windows implementation of the plugin
  • There is no test as of now in the federated_plugin_windows, because it will be the same as federated_plugin/federated_pluign/test. Instead, once Linux support is added, I can write an integration test for the federated_plugin/federated_plugin/example. Let me know your thoughts.
  • adds windows support for the federated_plugin/federated_plugin/example

Screenshot

Screenshot (217)
@AyushBherwani1998
adds support for windows
Loading status checks…
a24beb4
@AyushBherwani1998
fix nit
Loading status checks…
cfd905e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@AyushBherwani1998
You can’t perform that action at this time.