Skip to content

/ rake

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aborting `rake` execution needlessly dumps a backtrace #272

Open
booch opened this issue Aug 30, 2018 · 2 comments
Open

Aborting `rake` execution needlessly dumps a backtrace #272

booch opened this issue Aug 30, 2018 · 2 comments

Comments

@booch
Copy link

@booch booch commented Aug 30, 2018

When aborting rake with Ctrl+C, it outputs rake aborted! then dumps a long backtrace. This seems unnecessary, as aborting isn't really an unexpected outcome of pressing Ctrl+C (or sending an INT signal).

I'd like to propose catching the Interrupt exception and exiting cleanly (with an exit code of 1). We can still print the backtrace if the --trace option is used.

I can submit a pull request, if this seems reasonable.
@SwagDevOps
Copy link

@SwagDevOps SwagDevOps commented Sep 2, 2018

Exit code, should be more specific than 1: http://tldp.org/LDP/abs/html/exitcodes.html

sleep infinity
# Ctl-C
echo $?
# 130
@ret394
Copy link

@ret394 ret394 commented Apr 25, 2020 •
edited

ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x64-mingw32] & rake also dumps Traceback.

repo must mention code organization somewhere.

thanks. have a nice day. keep up the good work.

ret394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@booch @SwagDevOps @ret394
You can’t perform that action at this time.