Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOCGV: Move "Set cursor key to application mode" fix to gui.cs #99
Comments
tig
changed the title
tig
changed the title
|
Yeah I needed to bring it over to gui.cs but it was easier to just "fix it here" |
|
Thanks. I'm confused though. Why is this needed? Why is it needed AT EXIT? |
|
Very possible. |
|
btw if you ever need a cheap linux environment https://shell.azure.com is a great testing ground for OCGV behavior. |
|
Thanks. I actually use that (and WSL) here and there. The real problem is my dev skillz are barely adequate on Windows, and just getting started being able to enlist and build |
|
@TylerLeonhardt I got PS working on WSL and am sooo close. However, I can't figure out how to install dotnet core 3.1.102 on Ubuntu because the latest RPM installs 3.1.202. When I do
If I change
Any pointers appreciated. Sorry for posting here, but figured it'd be the best way to ask you. |
|
That second error is random and not our fault. Can you run it again? |
|
Different machine, same result. I've run it a dozen times. Has anyone else successfully built GraphicalTools on linux using {
"sdk": {
"version": "3.1.202"
}
} |
|
from your first screenshot it looks like you need to install zlib |
Nope, zlib is installed (via https://www.systutorials.com/how-to-install-the-zlib-library-in-ubuntu/). That was what I first tried. I believe this error is due to the fact I don't have donnetcore 3.1.102 installed. Because I can't easily install it. Because it's been superseded by 3.1.202.
I believe this because if I change |
|
can you delete the |
|
That was it. Thanks! Woot!
|
|
|
|
You've got that issue in gui.cs open now - can we close this one? |
|
It's not fixed here until it's fixed there. Isn't it best practice to leave the issue open until there's a PR that fixes the issue (in this case, deletes the code from |
|
@TylerLeonhardt Can you please comment out this fix and see if you can reproduce this? I cannot get this to reproduce on Linux under WSL. I've tried with both Windows Terminal and the WSL terminal. I don't have a mac to test on. I've double checked that I'm using my build of ocgv with that line commented out and that I did NOT fix it in I can't move this to |
|
Yeah I can't repro anymore. That's interesting. |
GraphicalTools/src/Microsoft.PowerShell.ConsoleGuiTools/ConsoleGui.cs
Line 295 in ad01f86
I think this may be a bug that impacts all
gui.csapps and should be fixed there. However, I don't fully understand what the user impact of the bug described in these comments was and how setting the cursor key to application mode fixed it. Can you provide more detail?As an aside, IIRC,
Disposefor a Cmdlet is not actually guaranteed to get called until the CmdLet's module is unloaded. And that does NOT happen immediately after the Cmdlet is run. ThisDisposegets called inOutConsoleGridviewCmdletCommand'sDispose. In buildingout-winprintI discovered that I could not count onDisposefor timely cleanup and instead had to do stuff at the end ofEndProcessing. This is another reason I think this logic should be moved togui.cs(unless I'm wrong about the fact the underlying bug impacts allgui.csapps).