In operations_broadcast_test.go there are some tests that are not yet filled in. The point is to test that broadcasting works for different shapes. The semantics of broadcast probably isn't clear, so please do send me a message for anything.

This is a good first issue for anyone looking to get interested

I'm using TF 2.0, and I get this error when I import tangent, due to a list of non-differentiable functions that includes tf.to_float (line 60), which is deprecated:

https://www.tensorflow.org/versions/r1.14/api_docs/python/tf/to_float

I found that function mod2pi is not implemented yet, but mod works. Is there any list of implemented functions? Minimal working example is:

using Zygote

# This is working
gradient(x -> mod(x, 2pi), 1.)

# This is not
gradient(x -> mod2pi(x), 1.)

Description

@JamesYang007 reports in their own repo readme) that there is an issue with math/stan/math/rev/functor/adj_jac_apply.hpp on line 513 and suggests adding a stan::math:: qualifier to the use of apply to avoid conflict with C++17.

Expected Output

Compilation in C++17 on GCC 10 without having to hand tweak the code.

At the moment profiles.h (in pkg/profiles) lacks many (any?) comments. Also lots of variables are declared somewhat separately from where they are associated with heap storage.

Both these make it a bit hard to read.

It would be nicer if it was called PROFILES.h too.

Zygote.ignore is a lovely piece of functionality that we aught to be able to provide at the ChainRulesCore-level. It would also be incredibly straightforward to implement.

It'll only work properly with Zygote-like ADs ofc, but it's an improvement over it not working at all.