Skip to content

/ commitizen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): rewrite cli instructions to be more succinct about what th… #259

Merged
merged 3 commits into from Sep 3, 2020
Merged

feat(cli): rewrite cli instructions to be more succinct about what th… #259

merged 3 commits into from Sep 3, 2020

Conversation

@alecgerona
Copy link
Contributor

alecgerona commented Sep 2, 2020 •
edited

Closes #258

Description

Rewrite cli instructions to be more succinct about what they require.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

1.Run cz c and view messages.
@alecgerona
feat(cli): rewrite cli instructions to be more succinct about what th…
Loading status checks…
dc816fd 
…ey require
@Woile
Woile reviewed Sep 2, 2020
View changes
commitizen/cz/conventional_commits/conventional_commits.py Outdated Show resolved Hide resolved
@Woile
Woile reviewed Sep 2, 2020
View changes
commitizen/cz/conventional_commits/conventional_commits.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          33       33           
  Lines         915      915           
=======================================
  Hits          884      884           
  Misses         31       31
Flag Coverage Δ
#unittests 96.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...en/cz/conventional_commits/conventional_commits.py 98.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efb23f...45ca91e. Read the comment docs.
alecgerona added 2 commits Sep 2, 2020
@alecgerona
fix(cli): wrap the word enter with brackets
39345b7
@alecgerona
fix(cli): add guideline for subject input
Loading status checks…
45ca91e
@alecgerona alecgerona requested a review from Woile Sep 2, 2020
@alecgerona
alecgerona reviewed Sep 3, 2020
View changes
commitizen/cz/conventional_commits/conventional_commits.py Show resolved Hide resolved
@Woile
Woile approved these changes Sep 3, 2020
View changes
@Woile Woile requested a review from Lee-W Sep 3, 2020
@Lee-W
Lee-W approved these changes Sep 3, 2020
View changes
Copy link
Member

Lee-W left a comment

LGTM.
@Lee-W Lee-W merged commit 683317b into commitizen-tools:master Sep 3, 2020
5 checks passed
5 checks passed
python-check (3.6)
Details
python-check (3.7)
Details
python-check (3.8)
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Woile Woile

@Lee-W Lee-W

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[Feature Request] Be more verbose about which input is required or optional
3 participants
@alecgerona @Woile @Lee-W
You can’t perform that action at this time.