Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchange default included scopes and add some documentation about scopes #42
Conversation
|
|
| NOTE: this feature is not available in the released version, only in the latest snapshot. | ||
|
|
||
| In general, it only makes sense to run missinglink for an executable artifact as opposed to a | ||
| library. The reason is that the exact set of dependencies that are included can change every time |
This comment has been minimized.
This comment has been minimized.
mattnworb
Sep 18, 2015
Member
I am not sure if I follow this totally or agree with the idea using missinglink on a library doesn't make sense.
A library might depend on two other libraries which have a shared dependency (let's say Guava) which had a breaking change between the version A was compiled against and the version B was compiled against. The library could depend on something in A or B which would break at runtime depending on which version of Guava was actually resolved.
Of course the "final" project using this library might introduce some new variation in the dependency tree that changes which version of Guava is resolved, perhaps in a way that causes the library to not have issues, or causes new issues. So I would say if a "final" project uses this library then it isn't enough, from the perspective of the final project, for the library to be checked with missinglink - ideally both should be scanning for issues like this.
| */ | ||
| @Parameter(property = "missinglink.includeScopes", defaultValue = "compile,test") | ||
| @Parameter(property = "missinglink.includeScopes", defaultValue = "compile") |
This comment has been minimized.
This comment has been minimized.
mattnworb
force-pushed the
spotify:master
branch
3 times, most recently
from
e16657a
to
3e16833
pettermahlen commentedSep 17, 2015
No description provided.