Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in build and update build script #252

Merged
merged 2 commits into from Sep 11, 2020

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Sep 11, 2020

Fix all warnings
Update build script to treat warnings as errors
Fix build script to fail early if build fails
Add -Clean switch to build script

dotnet publish will do a restore and build so those individual steps aren't needed

Update build script to treat warnings as errors
Fix build script to fail early if build fails
Add `-Clean` switch to build script
src/InstallHelper.cs Show resolved Hide resolved
src/PublishPSResource.cs Show resolved Hide resolved
Copy link
Collaborator

@PaulHigin PaulHigin left a comment

LGTM

@SteveL-MSFT SteveL-MSFT merged commit badf5cc into PowerShell:development Sep 11, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
license/cla All CLA requirements met.
Details
@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:fix-warnings branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.