Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Alignment of forms V2.10.1 - #1884

Open
phamorais opened this issue Jul 21, 2020 · 8 comments
Open

[Question] Alignment of forms V2.10.1 - #1884

phamorais opened this issue Jul 21, 2020 · 8 comments

Comments

@phamorais
Copy link

@phamorais phamorais commented Jul 21, 2020

Hello!
I don't think it's a BUG, ​​just a doubt

Version 2.9.2 had the style of the cards in a "centralized" way

image

After upgrading to v2.10.1 I checked the style returned to be left aligned

image

Has the alignment changed?

@btry
Copy link
Contributor

@btry btry commented Jul 21, 2020

Hi

This is maybe a side effect of a change in the CSS of the plugin. This is unintentional.

@phamorais
Copy link
Author

@phamorais phamorais commented Jul 23, 2020

@btry

I believe it is something from the new version 2.10.1.

I removed my CSS change, keeping the original form code

In Version 2.10.0 Cars are aligned to the center

image

with 2.10.1 the cards were left aligned

image

@btry
Copy link
Contributor

@btry btry commented Jul 24, 2020

Hi

I checked : the diff is empty between the tag v2.10.0 and v2.10.1 in css/styles.css or the masonry library.

On my instance I don't see any difference between those version. Are you sure the change does not appear between 2.9.x and 2.10.0 ?

@phamorais
Copy link
Author

@phamorais phamorais commented Jul 24, 2020

Hi @btry

In version 2.9.2 the cards are centered.

The print below is from my production environment and despite the change in styles, alignment has not changed.

I honestly don't know what it might be, but I realized that alignment to the left only happened after upgrading to 2.10.1

@btry
Copy link
Contributor

@btry btry commented Jul 24, 2020

Hi

I did not found yet what caused this change, and I don't have a lot of time to allocate to this minor change. Do you have ability to check the display with the version 2.10.0 ?

@phamorais
Copy link
Author

@phamorais phamorais commented Jul 24, 2020

@btry

I already did it.
In yesterday's post, the first image is with v2.10.0

image

It may seem like a small change without much value, but it is the interface presented to the customer. Everything that has a visual impact on the customer is always important :(

@btry
Copy link
Contributor

@btry btry commented Jul 24, 2020

I'll search soon how to restore the previous visual change.

@phamorais phamorais changed the title [Question] Alignment of forms - [Question] Alignment of forms V2.10.1 - Jul 24, 2020
@phamorais
Copy link
Author

@phamorais phamorais commented Jul 28, 2020

It's ok
Thank you @btry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.