Update serverlessservice_validation.go #159
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
knative-prow-robot
added
the
size/XS
| @@ -36,7 +36,7 @@ func (spec *ServerlessServiceSpec) Validate(ctx context.Context) *apis.FieldErro | |||
| return apis.ErrMissingField(apis.CurrentField) | |||
| } | |||
| var all *apis.FieldError | |||
| // Spec mode must be from the enum and | |||
| // Spec mode must be from the enum | |||
There was a problem hiding this comment.
Remove trailing whitespace:
| // Spec mode must be from the enum | |
| // Spec mode must be from the enum |
|
Welcome @NEERAJAP2001! It looks like this is your first PR to knative/networking |
|
Hi @NEERAJAP2001. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
needs-ok-to-test
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
Co-authored-by: Matt Moore <mattmoor@vmware.com>
|
@googlebot I signed it! |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, NEERAJAP2001 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Fixed a typo.