Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix test compile breaks and warnings #21
Open
Conversation
MSVC complains about narrowing conversions and unreferences parameters. This makes all tests almost level 4 warning clean on MSVC 14.
iterator is required for std::begin and std::end.
| @@ -18,6 +18,7 @@ | |||
| #include <iostream> | |||
| #include <list> | |||
| #include <vector> | |||
| #include <iterator> | |||
This comment has been minimized.
This comment has been minimized.
Flast
Jul 30, 2016
std::begin/end is came from C++11, so I think those should be replaced with boost::begin/end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarcelRaad commentedJul 19, 2016
•
edited
As the implicit get_error_info.hpp include was removed in #20 from hex.hpp, it's now required in hex_test4.cpp itself (sorry, I should have run the tests earlier!). Also fixed Visual C++ warnings in a separate commit.