skottler
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upPopular repositories
838 contributions in the last year
Activity overview
Contributed to
planetscale/vitess-framework-testing,
vitessio/website,
skottler/vitess
and 1 other
repository
Contribution activity
November 2020
Created 23 commits in 1 repository
Created 1 repository
Created a pull request in planetscale/vitess-framework-testing that received 5 comments
Get php/laravel passing against upstream 5.7
This pull request is intended to get the php/laravel framework passing against the 5.7 instance used in Actions today.
/cc #48
+3
−10
•
5
comments
Opened 15 other pull requests in 1 repository
planetscale/vitess-framework-testing
1
open
13
merged
1
closed
- Set the timeout to 10 minutes
- Replace Cargo.toml to include runtime/TLS feature
- Clone directly in the builds instead of using submodules
- Reinit submodules
- Fix rust and python submodules so they get checked out
- Run rust/sqlx tests inside container
- Remove standalone test script from ruby/rails
- Remove warning message from cases 003 and 004 in mysqldump/import
- Run each framework against vanilla MySQL 5.7
- Stand up mysql 8 in a container
- Run mysqldump framework test
- Execute validate_environment before running test
- Add shellcheck and framework_compare jobs
- Add script to run all tests serially
- Break out each framework into job via a matrix
Reviewed 12 pull requests in 1 repository
planetscale/vitess-framework-testing 12 pull requests
- Remove LOCK TABLES from mysqldump imports so we don't hang Vitess
- Fix haskell/mysql-haskell against vanilla MySQL; fixes #48
- frameworks/haskell: Optimize Dockerfiles for improved layer caching on local builds
- At the framework level, and in the python/sqlalchemy runner, when cleaning up tables between tests, explicitly drop any foreign keys before attempting to drop the tables
- Fix sqlalchemy (again)
- + frameworks/mysqldump/export
- + frameworks/mysqldump/import
- Small change to make `alltests.sh` only output the exit code of each test
- + Test for Haskell persistent-mysql
- test: Container image names can't have capital letters in them :(
- test: validate_environment(): Fix variable list passed to ensure_environment_variables(); add negation
- + haskell/mysql-simple
Created an issue in planetscale/vitess-framework-testing that received 2 comments
java/spring always passes when provided valid environment
The java/spring framework passes no matter being able to connect or do anything relevant to the database it gets configured against. This came up i…
2
comments
Opened 3 other issues in 1 repository
planetscale/vitess-framework-testing
3
closed
66
contributions
in private repositories
Nov 4 – Nov 26