Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese characters displayed as tofu #589

Open
xfq opened this issue Aug 19, 2020 · 3 comments
Open

Chinese characters displayed as tofu #589

xfq opened this issue Aug 19, 2020 · 3 comments
Labels
Projects

Comments

@xfq
Copy link

@xfq xfq commented Aug 19, 2020

Current behavior

First, thank you for working on Boost Note!

I used it for the first time today and encountered some issues: some Chinese characters can be displayed normally in the editor, but the rendering is "tofu" (i.e., font fallback box glyph). The four characters after # are 管理仓库 (all of them are common Simplified Chinese characters).

tofu

In Preferences > General, I tried changing the Interface Language to 中文 (CN), but the result is the same.

In Preferences > Editor, Editor Font Family is SFMono-Regular,Consolas,Liberation Mono,Menlo,monospace, which is the default value.

Expected behavior

管理仓库 should be rendered as... 管理仓库.

Steps to reproduce

  1. Open Boost Note
  2. Create a note
  3. Input "管理仓库"

Environment

Desktop

  • Boost Note.next version: 0.8.2
  • OS version and name: macOS 10.15.6
@Rokt33r Rokt33r added the bug 🐛 label Aug 28, 2020
@Rokt33r
Copy link
Member

@Rokt33r Rokt33r commented Aug 28, 2020

I think we should allow to customize UI fonts. @xfq Btw, which font would be the best for Chinese characters?

@Rokt33r Rokt33r added this to To do (High) in Dev kanban Aug 28, 2020
@xfq
Copy link
Author

@xfq xfq commented Aug 29, 2020

Here is a sans-serif font stack used in a project I'm involved in, for your reference:

https://github.com/w3c/clreq/blob/c545424c6829da35c819f851e8f347fd91e75aea/local.css#L1-L7

They are mainly fonts that come with operating systems. The advantage of this is that it matches what the current OS uses, so it can be a comfortable look.

@Rokt33r
Copy link
Member

@Rokt33r Rokt33r commented Sep 1, 2020

#492 This should be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev kanban
  
To do (High)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.