Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new stack implementation (ES6) fixes: #{246} #247

Merged
merged 3 commits into from Aug 20, 2020
Merged

new stack implementation (ES6) fixes: #{246} #247

merged 3 commits into from Aug 20, 2020

Conversation

@Makso83
Copy link
Contributor

Makso83 commented Aug 7, 2020

Welcome to JavaScript community

Describe your change:

  • [ *] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [* ] I have read CONTRIBUTING.md.
  • [* ] This pull request is all my own work -- I have not plagiarized.
  • [* ] I know that pull requests will not be merged if they fail the automated tests.
  • [* ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [* ] All new JavaScript files are placed inside an existing directory.
  • [ *] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ *] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ *] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Makso83
new stack implementation (ES6) fixes: #{246}
Loading status checks…
c7b59a7
@ruppysuppy
ruppysuppy suggested changes Aug 14, 2020
View changes
Data-Structures/Stack/StackES6.js Outdated Show resolved Hide resolved
itsvinayak and others added 2 commits Aug 20, 2020
@itsvinayak @ruppysuppy
Update Data-Structures/Stack/StackES6.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
df5de96 
Co-authored-by: Tapajyoti Bose <44058757+ruppysuppy@users.noreply.github.com>
@itsvinayak
Update StackES6.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db1f0d6
@itsvinayak itsvinayak merged commit e061178 into TheAlgorithms:master Aug 20, 2020
2 checks passed
2 checks passed
build (14.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruppysuppy ruppysuppy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Makso83 @ruppysuppy @itsvinayak
You can’t perform that action at this time.