Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patience sort algorithm #2380

Open
wants to merge 1 commit into
base: master
from
Open

Added patience sort algorithm #2380

wants to merge 1 commit into from

Conversation

@AbhiramRajeevan
Copy link

AbhiramRajeevan commented Sep 1, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@AbhiramRajeevan
Added patience sort algorithm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a0b28f
@TravisBuddy
Copy link

TravisBuddy commented Sep 1, 2020

Hey @AbhiramRajeevan,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dc26f3a0-ec3a-11ea-831e-55c1b07d6d51
@spamegg1
Copy link
Contributor

spamegg1 commented Sep 9, 2020

@AbhiramRajeevan Build log says

7 E111 indentation is not a multiple of four
2 E114 indentation is not a multiple of four (comment)
2 E302 expected 2 blank lines, found 1
1 E303 too many blank lines (3)
2 E704 multiple statements on one line (def)
5 W293 blank line contains whitespace

Can be easily fixed by running black on your file. CONTRIBUTING.md explains it, please read it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@AbhiramRajeevan @TravisBuddy @spamegg1
You can’t perform that action at this time.