Skip to content

/ sentry-python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis CI: Test on Python 3.9 release candidate 1 #808

Merged
merged 4 commits into from Sep 2, 2020
Merged

Travis CI: Test on Python 3.9 release candidate 1 #808

merged 4 commits into from Sep 2, 2020

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 2, 2020 •
edited

Xenial is already the default dist on Travis CI. (bionic and focal are also available)

Py39 in allow_failures mode until the GA release in one month. https://devguide.python.org/#status-of-python-branches

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks. https://devguide.python.org/devcycle/#end-of-life-branches

Also fixes:
Screenshot 2020-09-02 at 11 59 43
@cclauss
Travis CI: Test on Python 3.9 release candidate 1
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
26b9e55 
Xenial is already the default dist on Travis CI.  (bionic and focal are also available)

In allow_failures mode until the GA release in one month.  https://devguide.python.org/#status-of-python-branches

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks.  https://devguide.python.org/devcycle/#end-of-life-branches

Fixes:
@untitaker
untitaker requested changes Sep 2, 2020
View changes
Copy link
Member

@untitaker untitaker left a comment

Thanks for doing this, can you add py3.9 to tox.ini as well? There are potentially a few other jobs that would benefit from this.
@cclauss
tox.ini: py3.9
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ddf12e
@untitaker
Copy link
Member

@untitaker untitaker commented Sep 2, 2020 •
edited

here's a commit that added python 3.8: 9dc161b#diff-b91f3d5bd63fcd17221b267e851608e8

I am not sure if all the web frameworks we integrate with will run on Python 3.9 so it's probably too soon to add 3.9 to all of them

EDIT: Ah well you went for it, let's see
@untitaker
Copy link
Member

@untitaker untitaker commented Sep 2, 2020

Note: Python 3.4 is end of life and 3.5 will be end of life in two weeks.

You will be shocked to learn we support Python 2 :D
@untitaker
untitaker approved these changes Sep 2, 2020
View changes
@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 2, 2020 •
edited

Typos...
$ codespell . --ignore-words-list=ba,iam,referer,upto --skip=./.* --quiet-level=2

./CHANGES.md:205: Thansk ==> Thanks
./sentry_sdk/transport.py:375: instanciate ==> instantiate
./sentry_sdk/integrations/rq.py:42: Unparseable ==> Unparsable
./sentry_sdk/integrations/falcon.py:107: Unparseable ==> Unparsable
./sentry_sdk/integrations/sqlalchemy.py:34: Unparseable ==> Unparsable
./sentry_sdk/integrations/aiohttp.py:57: unparseable ==> unparsable
./sentry_sdk/integrations/sanic.py:49: Unparseable ==> Unparsable
./sentry_sdk/integrations/bottle.py:62: Unparseable ==> Unparsable
./sentry_sdk/integrations/redis.py:59: occured ==> occurred
./sentry_sdk/integrations/flask.py:70: Unparseable ==> Unparsable
@untitaker
Copy link
Member

@untitaker untitaker commented Sep 2, 2020

Thanks I fixed the typos on master
@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 2, 2020

Why test on pypy (Python 2.7) but not test on pypy3 (Python 3.6)?
@untitaker
Copy link
Member

@untitaker untitaker commented Sep 2, 2020

iirc Travis pypy3 used to be broken at some point and our usage stats didn't warrant extra effort.
cclauss added 2 commits Sep 2, 2020
@cclauss
TODO: celery-{4.1,4.2,4.3,4.4} Add py3.9
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c19bc73
@cclauss
fixup! pypy3.9
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea19446
@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 2, 2020

Pretty remarkable that celery is the only py39 TODO!
@untitaker untitaker merged commit 4aecbfd into getsentry:master Sep 2, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch/python Coverage not affected when comparing d1ee675...ea19446
Details
@untitaker
Copy link
Member

@untitaker untitaker commented Sep 2, 2020

Excellent, thanks!
@cclauss cclauss deleted the cclauss:patch-1 branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @untitaker