New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FreeBasic language #4998
Added FreeBasic language #4998
Conversation
I added FreeBasic language. Please see this.
|
What should I do? I did not understand. |
What should I do? I did not understand.
-
fill "I am adding a new language." section of the template in the OP. You can remove the other sections. Pay special attention to providing search results for all the extensions you're adding. If you don't meet the documented popularity requirements, the extension can't be added.
-
review the test failures. Most of these test failures are quite clear as to what the problems are and what you need to do to address them. Start with following those tips and explanations.
-
you're adding the
.incextension which, assuming it meets the popularity requirements specifically for FreeBasic, is already extensively used on GitHub and associated with several other languages too, so you will need to write a heuristic (ie a regex) that identifies FreeBasic.incfiles from the other languages and add it to this section:
linguist/lib/linguist/heuristics.yml
Lines 218 to 234 in 8083cb5
| - extensions: ['.inc'] | |
| rules: | |
| - language: Motorola 68K Assembly | |
| named_pattern: m68k | |
| - language: PHP | |
| pattern: '^<\?(?:php)?' | |
| - language: SourcePawn | |
| pattern: '^public\s+(?:SharedPlugin(?:\s+|:)__pl_\w+\s*=(?:\s*{)?|(?:void\s+)?__pl_\w+_SetNTVOptional\(\)(?:\s*{)?)' | |
| - language: NASL | |
| pattern: | |
| - '^\s*include\s*\(\s*(?:"|'')[\\/\w\-\.:\s]+\.(?:nasl|inc)\s*(?:"|'')\s*\)\s*;' | |
| - '^\s*(?:global|local)_var\s+(?:\w+(?:\s*=\s*[\w\-"'']+)?\s*)(?:,\s*\w+(?:\s*=\s*[\w\-"'']+)?\s*)*+\s*;' | |
| - '^\s*namespace\s+\w+\s*{' | |
| - '^\s*object\s+\w+\s*(?:extends\s+\w+(?:::\w+)?)?\s*{' | |
| - '^\s*(?:public\s+|private\s+|\s*)function\s+\w+\s*\([\w\s,]*\)\s*{' | |
| - language: POV-Ray SDL | |
| pattern: '^\s*#(declare|local|macro|while)\s' |
More information is in the CONTRIBUTING.md file
|
I don't understand here yet |
|
All checks passed, now you can commit. I only left .bi files |
|
This PR still needs a sample FreeBasic There's also the issue with other Most of those appear to be FreeBasic, but quite a few of those appear to be QBasic which means this PR will also need to add support for QBasic and a heuristic to differentiate between the two. |
|
I did everything |
|
I added .bas extension too. |
What for? |
|
How do you fix this conflict? I added BASIC to fix it, but the check does not go (Waiting for status to be reported). |
|
I've fixed the merge conflicts for you. We might need to tweak things further, but we'll see once the tests have run. |
Thank you. |
I added FreeBasic language. Please see this.
Description
Checklist: