Brett Fox's answer to When VCs say the giants will enter the market and put you out of business in a day, what is the best answer you can give? - Quora





July 19, 2019 at 01:27PM

via Instapaper https://ift.tt/32B5pTS

Currently certain PR's coming from forks result in the action running in the context of the fork, which means it can't post a comment or a PR review to the PR/issue.

Possible workarounds:

1. Report the size table back using a Status Check
   • Not sure if GitHub's UI will handle

Only a subset of the inputs documented are actually allowed in the action.yml, resulting in the following warning when I use customParameters, versioning, and other parameters:

##[warning]Unexpected input 'customParameters', valid inputs are ['unityVersion', 'targetPlatform', 'projectPath', 'buildName', 'buildsPath', 'buildMethod']

As Queue::hasPushed(QueueableActionJob::class) wont work, it might be nice to include some assertions out of the box?

    public function actionJobWasPushed(string $actionJobClass): bool
    {
        $this->assertTrue(Queue::getFacadeRoot() instanceof QueueFake, 'Queue was not faked. Use `Queue::fake()`.');

        return collect(Queue::pushedJobs()[ActionJob::class] ?? [])