rakyll
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
557 contributions in the last year
Contribution activity
September 2020
Created a pull request in open-telemetry/opentelemetry-go that received 7 comments
Convert XConfigure into constructors
Previously, we discussed the possibility of converting the config types into internal ones. But due to the cyclic dependencies it introduces, we ar…
+39
−26
•
7
comments
- Merge otel into one file and add package doc
- Convert XConfigure into constructor for metrics
- Add the missing vanity import path directive
- Rename package.go to doc.go for consistency
- Document `make test` for testing
- Add receiver names to TraceContext methods
- Add missing argument names to the Span interface
- Unexport NoopXXX trace types
- Added missing package document and canonical import paths
Created an issue in open-telemetry/opentelemetry-specification that received 11 comments
Rename the protocol to OTELP
(Sorry for filing a first issue that is a bikeshedding one.) The OpenTelemetry protocol is shortened as OTLP but it soudns very similar to OLTP whi…
11
comments
- Reconsider the context keys
- Can tracetest.SpanRecorder be a concrete type?
- go test ./... and make build fails differently
- Unexport NoopXXX
- trace.EmptySpanContext is not needed
- http.Request as a first class object for HTTPPropagator interfaces
- Moving SpanConfig and TracerConfig to internal
- Find a way to avoid both having tracetest.MockSpan and tracetest.Span
- Move b3 under propagation/b3?
- Is codes package a part of the API?
- Consider moving tools into internal?
3
contributions
in private repositories
Sep 7 – Sep 8